Fix draft watermark for short content #895
Conversation
|
You can see that So I'd look at using a fallback some variation of Also, how does this work with print styles, is this respected? |
|
@NickColley Printing does print background images. |
|
I've changed the required status checks for this repo. You'll need to rebase this branch against master so that this branch gets a Jenkinsfile can be built against new CI. |
|
Pragmatically I think this is an enhancement and we don't need a fallback. IE8 has functional support. |
|
Since the biggest issue is on smaller viewports and they tend to be mobile clients that have support for contain, I'd say 👍 |
Some content is clipping the draft background watermark. This commit adds `background-size: contain` to avoid this.
gpeng
force-pushed
the
fix-draft-background-for-short-content
branch
from
9f3f191
to
20d906e
Compare
|
Thanks all. Post approval commit is just a rebase to pick up @36degrees's Jenkins business... |
Some content is clipping the draft background watermark. This commit adds
background-size: containto avoid this.Before:
After:
Before:
After:
I've not tested the effect on IE so would welcome an opinion on that.
/cc @fofr (thanks for the pointer on how to fix), @NickColley